Generalised surface fitting #122
Conversation
… from the global parameters. 'calc_scale_factors_2d' rewritten to be more specific to the surface meshes used in the code, along with specific functions for 'hermite' and 'linear' interpolation
…just the location of specified nodes so that they remain on the fitted surface but are spread evenly between user-specified nodes
…t this is done automatically. we always need an ordered tree
…laced dabs with abs in gas_exchange.f90
… up lines on a 2d mesh
Unit ventilation
There was a problem hiding this comment.
Requesting changes
- Remove _WIN32 in bindings
- Remove changes to gas_exchange in bindings , although minor
- Remove changes to gas_exchange.f90 in bindings
- Remove changes to gas_exchange.h in bindings
- Remove changes to argument list in add_mesh in geometry.c
- Remove refine_1d_elements, renumber_tree_in_order from geometry.c
- remove default_lung_mechanics from arrays.f90
- Remove changes to capillary flow.f90
- Remove DEC$ ATTRIBUTES from export_lagrange
- Remove all changes in lib/gas_exchange.f90 this should be a different PR
- Remove all changes in lib/ventilation.f90 this should be a different PR
… gas_exchange in lib
…pdate parameters from bindings and lib
…se_lung_volume from geometry.f90 and bindings, and added set_initial_volume back in
|
Have made all requested changes and have updated the accompanying test example (pushed to get_surf_fit_issue44) |
|
Requesting minor changes: [src/bindings/c/ventilation.f90] src/lib/geometry.f90 Otherwise the build is fine. When running associated example, I get segmentation error right at ITERATION 1. |
…in line_versn_2d not global nodes. seg fault found as part of code review by HK. error picked up using pedantic build
|
Happy with changes in this PR. Few things to note for future version releases of this code:
Can be merged now. |
Addresses issue #121. Option to 'import' nodes (useful when editing nodes in cmgui during fitting) and to distribute nodes evenly along an arc length in between fit iterations.